RDKEMW-21870: PDRI flash failed but logline show successfull - #277
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts rdkv_upgrade logging/formatting to prevent misleading “PDRI flash successful” messages when the flash operation actually fails.
Changes:
- Gate the “PDRI image Flash upgrade successful” log line on
flash_status == 0. - Normalize the
state_red_retcheck block formatting (line ending/whitespace cleanup).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.